feat(timing): compatability with corrections generated in real-time - #17
Conversation
|
@danielemichilli This PR should enable you to load timing correction files generated by both the offline and real-time pipeline. It also adds a where |
|
@ssiegelx I was finally able to test this, sorry about the huge delay. The new function formally works but the correction I get is different from the previous version. |
4e8cf22 to
20bf18a
Compare
|
Requires chime-experiment/chimedb_di#30 |
- The TimingCorrection.from_acq_h5 method will now automatically recognize the chime_delay acquisition files that are generated by the real-time pipeline, and use a specialized method for generating a valid timing correction from these files. - Add a predict_x_error method to the TimingCorrection class, which will predict the offset in the telescope x position of sources due to the measured timing variations.
890fe84 to
2b4c226
Compare
ketiltrout
left a comment
There was a problem hiding this comment.
I think this is ready to go, but needs to wait for the chimedb PR to get merged first.
That PR is waiting on some alpenhorn testing I hope to do this week.
The TimingCorrection.from_acq_h5 method will now automatically
recognize the chime_delay acquisition files that are generated
by the real-time pipeline, and use a specialized method for
generating a valid timing correction from these files.
Add a predict_x_error method to the TimingCorrection class,
which will predict the offset in the telescope x position of sources
due to the measured timing variations.