Skip to content

feat(timing): compatability with corrections generated in real-time - #17

Merged
ssiegelx merged 3 commits into
masterfrom
ss/timing-rt-update
Aug 20, 2025
Merged

feat(timing): compatability with corrections generated in real-time#17
ssiegelx merged 3 commits into
masterfrom
ss/timing-rt-update

Conversation

@ssiegelx

Copy link
Copy Markdown
Contributor
  • The TimingCorrection.from_acq_h5 method will now automatically
    recognize the chime_delay acquisition files that are generated
    by the real-time pipeline, and use a specialized method for
    generating a valid timing correction from these files.

  • Add a predict_x_error method to the TimingCorrection class,
    which will predict the offset in the telescope x position of sources
    due to the measured timing variations.

@ssiegelx
ssiegelx requested a review from danielemichilli May 10, 2021 16:13
@ssiegelx

Copy link
Copy Markdown
Contributor Author

@danielemichilli This PR should enable you to load timing correction files generated by both the offline and real-time pipeline.

It also adds a predict_x_error method to the TimingCorrection class that you should use instead of the version in the baseband-analysis.localization module. It is called as:

dx = tcorr.predict_x_error(timestamp, input_map=input_map)

where input_map is the output of ch_util.tools.get_correlator_inputs. Note that if you do not provide the input_map argument, then the code will query the layout database for this information. This query is the slowest part of the routine, so if you are calling it many times you may want to pass it as an argument.

@danielemichilli

Copy link
Copy Markdown

@ssiegelx I was finally able to test this, sorry about the huge delay.

The new function formally works but the correction I get is different from the previous version.
For example, I am testing TOA = 1553730069.4198346138, are you able to doublecheck the correct value I should be getting for that timestamp?

@ssiegelx
ssiegelx requested a review from ketiltrout April 11, 2022 14:55
@ketiltrout
ketiltrout force-pushed the ss/timing-rt-update branch from 4e8cf22 to 20bf18a Compare August 19, 2025 19:35
@ketiltrout

Copy link
Copy Markdown
Member

Requires chime-experiment/chimedb_di#30

Seth Siegel and others added 2 commits August 19, 2025 12:54
- The TimingCorrection.from_acq_h5 method will now automatically
recognize the chime_delay acquisition files that are generated
by the real-time pipeline, and use a specialized method for
generating a valid timing correction from these files.

- Add a predict_x_error method to the TimingCorrection class,
which will predict the offset in the telescope x position of sources
due to the measured timing variations.
@ketiltrout
ketiltrout force-pushed the ss/timing-rt-update branch from 890fe84 to 2b4c226 Compare August 19, 2025 19:54

@ketiltrout ketiltrout left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go, but needs to wait for the chimedb PR to get merged first.
That PR is waiting on some alpenhorn testing I hope to do this week.

@ssiegelx
ssiegelx merged commit a3fec44 into master Aug 20, 2025
5 checks passed
@ssiegelx
ssiegelx deleted the ss/timing-rt-update branch August 20, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants