Skip to content

Conversation

@ayushnix
Copy link
Contributor

@ayushnix ayushnix commented Jan 2, 2026

Description

updated fish-shell to 4.3.3

The none-profile.patch is the same as before but created with git-format-patch.

fixed cross compilation by defining target triplet explicitly, this was introduced in the following commit

fish-shell/fish-shell@205d80c

python-sphinx is now needed to build man pages and documentation but it doesn't work when cross compiling fish

fish-shell/fish-shell@135fc73

Since cross compiling introduces errors because of python-sphinx, I added it only if cross compiling is not being done. This results in the fish-shell-man autopackage not being created when cross compiling fish. Is is this okay or should I disable cross compilation for this package completely?

Checklist

  • I have read CONTRIBUTING.md
  • I acknowledge that overtly not following the above or the below will result in my pull request getting closed
  • I have read Packaging.md
  • I have built and tested my changes on my machine

@ayushnix
Copy link
Contributor Author

ayushnix commented Jan 2, 2026

Hmm, looks like pre-build docs were removed from 4.3.0. I'll push a fix soon.

The none-profile.patch is the same as before but created with
git-format-patch.

fixed cross compilation by defining target triplet explicitly, this was
introduced in the following commit

fish-shell/fish-shell@205d80c

python-sphinx is now needed to build man pages and documentation but it
doesn't work when cross compiling fish

fish-shell/fish-shell@135fc73
@ayushnix ayushnix changed the title user/fish-shell: update to 4.3.2 user/fish-shell: update to 4.3.3 Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant