Fix bug that sometimes causes random distortion. (clear the floating point state at start too)#12
Open
TomArrow wants to merge 1 commit into
Open
Fix bug that sometimes causes random distortion. (clear the floating point state at start too)#12TomArrow wants to merge 1 commit into
TomArrow wants to merge 1 commit into
Conversation
…point state at start too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not quite sure this is the correct solution but made sense to me based on my limited understanding, and it seems to get rid of the issue from a quick check.
Basically I think that for random reasons (probably not really random) the floating point state can end up having the invalid flag set, and apparently it must always be cleared. And here it is only cleared after doing the first check, but at that point it's already too late. So the first value in the array gets corrupted (overwritten with the clip value) but the rest is fine because then the floating point invalid flag is cleared.