(GH-30) Add ability to compare meta information of found binaries#35
(GH-30) Add ability to compare meta information of found binaries#35AdmiringWorm wants to merge 2 commits intochocolatey-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
- Coverage 100.00% 92.59% -7.41%
===========================================
Files 14 14
Lines 173 189 +16
===========================================
+ Hits 173 175 +2
- Misses 0 14 +14
Continue to review full report at Codecov.
|
|
@mkevenaar would you have the possibility to take a look at the current implementation in this draft? It is not completely ready yet, but I would like to get some feedback before going any further with this. Sorry about the changes to the formatting, this was a mistake due to automatic formatting in vscode. I will revert those changes when the PR is ready |
|
|
||
| foreach ($path in @($oldExtractPath; $newExtractPath)) { | ||
| # Only because of unit tests | ||
| if (!(Test-Path $path)) { continue; } |
There was a problem hiding this comment.
Why is this there? What is the use of this?
I think you'll need to create Mocks to get around this.
There was a problem hiding this comment.
I don't remember right now, I have had this code in a stash for quite some time.
I remember that the unit tests were failing until I added this statement, but the unit tests have been updated since the initial stash creation so it may not be needed any longer.
The comment was also more a reminder to myself to figure out why the unit test was failing.
There was a problem hiding this comment.
The Pester tests mock the folder and should not actually go out on the internet to download an actual package. I guess it's due to that.
You'll do need to make actual Pester tests.
89b6799 to
cebbf8b
Compare
|
I have moved most of the relevant code to a new function. |
Description
This pull requests adds the ability to store and compare basic information of the included binary files in each package version.
Related Issue
fixes #30
Motivation and Context
To be able to easier notice the changes regarding binary files between each version.
How Has This Been Tested?
Currently only been tested in a remote devcontainer in vscode.
Screenshots (if appropriate):
Types of changes
Checklist:
Additional
This pull request is currently a WIP, unit tests have not yet been added nor completely tested appropriately.
Wanted to get some feedback on the current implementation before going any further with this one.
example output: