Add Battle.net package recipe#8
Open
Zoullx wants to merge 1 commit intochocolatey-community:masterfrom
Open
Conversation
TheCakeIsNaOH
requested changes
Feb 5, 2023
Member
TheCakeIsNaOH
left a comment
TheCakeIsNaOH
left a comment
There was a problem hiding this comment.
Thanks for bringing this package over here, sorry it took so long to take a look at it.
| @@ -0,0 +1,101 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- Read this before creating packages: https://docs.chocolatey.org/en-us/create/create-packages --> | |||
Member
There was a problem hiding this comment.
The default comment in this file can be removed.
| This package requires the `autohotkey` chocolatey package | ||
| This package requires the `chocolatey-misc-helpers.extension` chocolatey package | ||
|
|
||
| The updater requires a properly configured installation of [AU](https://github.com/majkinetor/au) |
Member
There was a problem hiding this comment.
Probably best to mention chocolatey-au here as well.
| $fileLocation = Join-Path $toolsDir 'Battle.net-Setup.exe' | ||
| $checksumType = 'sha256' | ||
|
|
||
| Invoke-WebRequest $url -OutFile $fileLocation -UseBasicParsing |
Member
There was a problem hiding this comment.
There is not really any point in downloading the file beforehand to get the checksum for Install-ChocolateyPackage, at least security wise.
|
|
||
| ### Notes: | ||
|
|
||
| The Battle.net Launcher is built on demand when downloaded, so the checksum will be calculated on demand to be provided to `Install-ChocolateyPackage` |
Member
There was a problem hiding this comment.
Since this package would only be used in internal repositories, it probably would make more sense to embed the installer in the package. But I'm open to discussion on this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updates to the Battle.net chocolatey package can't be pushed to the public feed because the executable is built on demand and therefore has a different checksum every time it's downloaded. But I would still like to submit the updates somewhere so that the community can access a working Battle.net chocolatey package.