(#1141) Update FlaUI tests with feedback#1142
Merged
Merged
Conversation
Update the usage of UIA2 to be UIA3 as UIA3 is the recommended class. chocolatey#1134 (comment)
Update the use of Find..Descendant to be Find..Child where applicable. When we don't need a deeper descendant, Find..Child is much faster. chocolatey#1134 (comment)
Update to the latest version of NUnit 4.x, to allow us to use FlaUI.TestFixture. This requires some changes to existing assertions, but allows greater clarity in the tests. This also adds NUnit.Analyzers to allow us to make use of Visual Studio suggestions for NUnit best practices.
Remove the base test class that we duplicated from FlaUI and instead use FlaUI.TestUitility. chocolatey#1134 (comment)
Add a few null checks to make errors in UITests easier to locate.
12 tasks
|
Skimmed thru it, LGTM |
vexx32
approved these changes
Jun 2, 2026
vexx32
left a comment
vexx32
left a comment
Member
There was a problem hiding this comment.
These changes look good to me, thanks for sorting these out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the FlaUI tests with feedback from #1134.
Motivation and Context
Try to follow best practices for FlaUI.
Testing
See testing directions for #1134
Operating Systems Testing
Dev VM 4
Change Types Made
Change Checklist
Related Issue