(#440) Fix dynamic code block issue with regex#464
Merged
st3phhays merged 3 commits intoJun 18, 2025
Conversation
Added regex to find exact match when doing a replace all in the dynamic code block. This fixes issue when multiple inputs are used on a page and one input name or variable has no number but other inputs do have a number in the name attribute variable it doesn't break the find and replace functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Added regex to find exact match when doing a replace all in the dynamic code block.
Motivation and Context
This is necessary to fix issue where having multiple dynamic code block inputs on a page and one input name or variable has no number but other inputs do have a number in the name attribute variable it was causing the find and replace functionality in the dynamic code block component to break.
Testing
gh pr checkoutyarn build.yarn link choco-theme.<DynamicCodeBlockInput />and<DynamicCodeBlock />.<DynamicCodeBlockInput />components with the following names: codeBlockReplace, codeBlockReplace2, codeBlockReplace3.<DynamicCodeBlock />with code and include the 3 replace variables within the code.Operating Systems Testing
n/a
Change Types Made
Change Checklist
Related Issue
#440
Fixes #440