Skip to content

Optimize checking of unsupported values in CouplesBitSetTable #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsimomaa
Copy link
Contributor

Optimize checking of unsupported values in CouplesBitSetTable #1160

@cprudhom
Copy link
Member

Hi

Thank you for PR.
Do you need help to make all tests pass?

In addition, did you test other algorithm for binary table?
I'm not 100% sure that AC3bitrm is the most efficient and/or in which cases it is the most relevant to use

@jsimomaa
Copy link
Contributor Author

Hi

Thank you for PR. Do you need help to make all tests pass?

In addition, did you test other algorithm for binary table? I'm not 100% sure that AC3bitrm is the most efficient and/or in which cases it is the most relevant to use

Hi,

I just ran out of time but I'll try to check the tests shortly.

We initially used CT+ but had some OutOfMemory issues thus we changed to AC3bit+rm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants