Skip to content

Conversation

@melissapathil
Copy link

@melissapathil melissapathil commented Nov 14, 2025

/playground/notebooks/pale_toolkit.ipynb initial notebook for ddG and uncertainty BAR estimates with NEQ cycles
/playground/protein-mutation/ABL-ATP directory with sample data for Abl-ATP

Estimating $\Delta\Delta G$ and Uncertainty using PyMBAR

  • is_cycle_complete : check if given CycleUnit directory has completed results
  • get_num_cycles : get minimum number of completed cycles across mutations to compare BAR estimates
  • load_work_arrays : load work values stored in npy arrays of completed cycles
  • get_uncertainty: estimate uncertainty by taking standard deviation of bootstrapped BAR-estimated free energies
  • plot_works : plot work trajectories and distributions
  • compute_ddG_estimate : compute ddG and uncertainty using MBAR

@ijpulidos ijpulidos changed the title new branch for pale-toolkit Notebook with FE estimate and trajectory construction Nov 14, 2025
@ijpulidos
Copy link
Contributor

ijpulidos commented Nov 14, 2025

At first glance, I noticed that we probably don't want to add all the serialized JSON files in the code base. I presume they should be easy to generate with the notebook, correct? If not, then we just probably want one or two examples that can be used to illustrate the functionalities implemented in the notebook.

EDIT: Similarly with the PDBs

@ijpulidos
Copy link
Contributor

These json files from the ABL+imatinib notebook, they were probably added to the commit by mistake.

@melissapathil
Copy link
Author

melissapathil commented Nov 16, 2025

I added the notebook for FE estimates and plotting work trajectories/distributions. I'm having trouble updating the branch with scripts and data for Abl-ATP but I'll try to get that up soon.

Update: scripts, data, and analysis notebook added! I'll convert this to a PR after adding some notes.

@melissapathil melissapathil marked this pull request as draft November 16, 2025 18:19
@melissapathil melissapathil changed the title Notebook with FE estimate and trajectory construction Notebook + sample data for estimating FE and uncertainty Nov 18, 2025
@melissapathil melissapathil marked this pull request as ready for review November 18, 2025 17:27
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The notebook is looking great.

I made some comments, but overall just avoiding having too many files (maybe we want to showcase the toolkit/utilities just with a couple of cycle results or so)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to be storing the checkpoint files in the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook looks very good, I think we probably want to have one that showcases the functions (shows plots, ddg estimates, etc.) for a couple of cycles or something like that if possible. That way we don't have to store all the results files which are not great to have on the repo.

We probably also want the notebook having the outputs (at least the "useful" ones, like plots and DDGs or similar).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we don't want to store checkpoints.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samples of these plots should probably be in the notebook itself. That way we can showcase the tools and the results in the same file, and avoid having PNG(binary) files around as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to store these scripts to run the DAGs as part of this set of changes. If there are improvements from the current scripts in the playground directory we probably want to make a new PR improving these, or adding new ones if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants