Skip to content

Fix DatabasePropertyFilter.select - #60

Open
rock88 wants to merge 1 commit into
chojnac:mainfrom
rock88:fix-select-filter
Open

Fix DatabasePropertyFilter.select#60
rock88 wants to merge 1 commit into
chojnac:mainfrom
rock88:fix-select-filter

Conversation

@rock88

@rock88 rock88 commented Apr 9, 2025

Copy link
Copy Markdown

Hello! According to Notion’s documentation, the select filter does not support the contains option. Instead, the equals option should be used:

Screenshot 2025-04-09 at 20 21 41

I added SelectCondition to support this, but it's the same as StatusCondition, so feel free to suggest your ideas on how to reduce code duplication. For example, using a typealias could be an option:

extension DatabasePropertyFilter {
    public typealias SelectCondition = StatusCondition
}

Or extract it into a new generic condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant