Cosmo dynamical de test#506
Open
mabruzzo wants to merge 4 commits into
Open
Conversation
Merged
mabruzzo
force-pushed
the
cosmo_dynamicalDE-test
branch
from
db9761d to
0f4540c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after PR #500 has been merged
This PR tries to add some basic tests related to the new
TabulatedDynamicalDarkEnergyEoStype introduced in PR #500. Most of these tests focus on catching slightly invalid file formats.I did slightly restructure the construction logic of
TabulatedDynamicalDarkEnergyEoSto make it easier to test. But I was very careful to avoid breaking things. @astrodiegog, let me know if you have concerns.Ideally, it would be great to perform an actual test to confirm that the value returned by dynamic eos table the expected answer given a table. But I haven't really dug into the logic (@astrodiegog, I'm happy to take suggestions). Right now we just check the most extreme values since that was simple