Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-2.0 #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apache-2.0 #582

wants to merge 1 commit into from

Conversation

yoshuawuyts
Copy link
Member

Changes the Choo license to Apache 2 as per choojs/discuss#1. Thanks!

@goto-bus-stop
Copy link
Member

Seems good, anything blocking this?

@YerkoPalma
Copy link
Member

Is there any reason for this PR and #587 to be on hold?

@yoshuawuyts

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright {yyyy} {name of copyright owner}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ 2018 Yoshua Wuyts ^

@ungoldman
Copy link
Member

This looks ok to merge once line mentioned in comment is fixed.

@brodycj
Copy link

brodycj commented Feb 23, 2018

I am very sorry to be a pain but is this approved by all people listed in https://github.com/choojs/choo/graphs/contributors? I think this is needed to switch from MIT to Apache 2.0 license.

Bootstrap had to go through this kind of process to move from Apache 2.0 to MIT (needed to integrate with Drupal which is GPL v2) as discussed in twbs/bootstrap#2054 (see also [1]). As described in twbs/bootstrap#2054 (comment) they did have to revert and redo a few commits to do this properly.

As another example NPX has to go through the same thing to switch from CC0 to ISC license [2].

I would personally favor just adding Apache 2.0 license option if it is possible to get the needed approval. Apache 2.0 only license could be an issue in case of Drupal and other GPL v2 frameworks as discussed in twbs/bootstrap#2054.

[1] https://opensource.stackexchange.com/questions/6097/how-does-bootstrap-v4-mit-deal-with-contributions-made-under-v3-apache-2-0
[2] zkat/npx#132

@timwis
Copy link
Member

timwis commented Feb 24, 2018

That requirement sounds a bit silly, particularly if someone only PRd a typo a year ago, but for what it's worth, it's good by me!

@goto-bus-stop goto-bus-stop mentioned this pull request Mar 9, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants