update changes based on driftscan - #4
Open
Arnab-half-blood-prince wants to merge 1 commit into
Open
Conversation
mwilensky768
approved these changes
May 28, 2026
Contributor
Author
|
I think, we should wait till the PR of driftscan gets merged to radiocosmology main branch. Then we can just use the main branch within chord repo, instead of using forked branch. This PR can be useful now to run on our own work. |
|
@Arnab-half-blood-prince I've approved the changes based on your testing but maybe we should wait to merge for when radiocosmology/driftscan#134 gets merged. |
Contributor
Author
|
I ran a full sim for CYG-A for the testing. Here are the plots. It looks okay. I will wait till driftscan PR gets merged and then merge this branch . 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch tracks the changes in latest driftscan changes.