Picarto plugin: update RTMPStream settings #1469
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Latent-Logic
suggested changes
Sep 25, 2016
src/livestreamer/plugins/picarto.py
Outdated
|
|
||
| _channel_casing_re = re.compile(r""" | ||
| <script>placeStreamChannel\('(?P<channel>[^']+)',[^,]+,[^,]+,'(?P<visibility>[^']+)'\);</script> | ||
| <script>placeStreamChannelFlash\('(?P<channel>[^']+)',[^,]+,[^,]+,'(?P<visibility>[^']+)',[^,]+\);</script> |
There was a problem hiding this comment.
Please take a look at my comments in PR #1332. The matching of placeStreamChannelFlash works if a single person is streaming, or placeStreamChannel if they are involved with a multistream. The following works for both as long as it isn't a multistream where the primary streamer is offline
<script>placeStreamChannel(Flash)?\('(?P<channel>[^']+)',[^,]+,[^,]+,'(?P<visibility>[^']+)'(,[^,]+)?\);</script>
If the page you go to is involved in a multistream and the primary streamer (the one who's page you went to) is offline, but the secondary or tertiary stream is live, it will incorrectly match the second or third stream instead of (correctly) reporting the stream offline.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed RTMPStream-settings to match the August 30th Picarto update.