Skip to content

Conversation

@markeganfuller
Copy link
Contributor

@markeganfuller markeganfuller commented Nov 3, 2025

Copy link
Owner

@chris-reeves chris-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @markeganfuller, great to hear from you - I hope all is well with you!

Thanks for raising this PR - we definitely need to remove untaint to support recent (i.e. current!) ruby versions.

I'm not so keen on switching to anonymous block forwarding though, as that bumps the minimum required ruby version to 3.1 with no real benefit. Granted, even 3.1 is out of support now, but there are no doubt some users out there with ancient ruby versions and I'd rather not cause them unnecessary pain.

Would you mind dropping the anonymous block forwarding commit and reverting the required ruby version to 2.3.0? Could we also restore the older rubies to the testing matrix? I'm happy to drop older versions from the testing matrix if the latest Gemfile.lock ends up causing them issues, but lets at least give them a chance. :-)

@markeganfuller markeganfuller changed the title Upgrade to 3.x and remove use of untainted Add new versions to workflow and remove use of untainted Nov 17, 2025
@markeganfuller
Copy link
Contributor Author

Hi @chris-reeves, things are slowly moving forward here as usual!

I've dropped the version updates (beyond 2.7.7 -> 2.7.8 as the lint failed to run) and anonymous forwarding.

@chris-reeves chris-reeves merged commit 3088a42 into chris-reeves:main Nov 17, 2025
11 checks passed
@markeganfuller markeganfuller deleted the remove_untainted branch November 18, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants