Use is_callable instead of method_exists to check for setup/teardown#360
Open
bendmorris wants to merge 1 commit intochrisboulton:masterfrom
Open
Use is_callable instead of method_exists to check for setup/teardown#360bendmorris wants to merge 1 commit intochrisboulton:masterfrom
bendmorris wants to merge 1 commit intochrisboulton:masterfrom
Conversation
…methods `method_exists` will return true even if an object has a protected method; calling it from Resque will then fail. `is_callable` only returns true when the method both exists and can be called externally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
method_existswill return true even if an object has a protected method; calling it from Resque will then fail.is_callableonly returns true when the method both exists and can be called externally.