Merged
Conversation
The chaos tests weren't waiting for all tasks to be _received_ (only sent). This was masking some other problems, like that the test could never fully finish if any `toxic` tasks had been sent (since they would die 100% of the time).
|
📚 Documentation has been built for this PR! You can download the documentation directly here: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 3223 3223
Branches 183 183
=========================================
Hits 3223 3223
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chaos tests weren't waiting for all tasks to be received (only
sent). This was masking some other problems, like that the test could
never fully finish if any
toxictasks had been sent (since they woulddie 100% of the time).