Add in_ and at helpers to allow for directly requesting a retry#130
Conversation
chrisguidry
left a comment
There was a problem hiding this comment.
The API looks great, and it's super cool we could implement this without changing worker. It does mean that what shows up in the logs is a task failure, which I'm good with right now. We may find that we want these to be treated as "normal" flow-control exceptions and not log them as failures, but this is a great first step.
Another thing I was thinking about: what happens if someone calls ExponentialRetry.in_(...)? Maybe ExponentialRetry shouldn't have a minimum_delay attribute, but re-use the delay attribute from the base Retry?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 3223 3293 +70
Branches 183 186 +3
=========================================
+ Hits 3223 3293 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0d3c14c to
f0d1a6f
Compare
|
I believe the docs failure here is because this came in from a fork, rather than being part of this repo directly. |
Closes #129