Skip to content

Add Valkey support to test matrix #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisguidry merged 1 commit into from
Jun 20, 2025
Merged

Add Valkey support to test matrix #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.12", "3.13"]
redis-version: ["6.2", "7.4"]
redis-version: ["6.2", "7.4", "valkey-8.0"]
redis-py-version: [">=4.6,<5", ">=5"]

steps:
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co

**Docket** (`pydocket` on PyPI) is a distributed background task system for Python functions with Redis-backed persistence. It enables scheduling both immediate and future work with comprehensive dependency injection, retry mechanisms, and fault tolerance.

**Key Requirements**: Python 3.12+, Redis 6.2+
**Key Requirements**: Python 3.12+, Redis 6.2+ or Valkey 8.0+

## Development Commands

Expand Down
9 changes: 8 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,15 @@ def redis_server(testrun_uid: str, worker_id: str) -> Generator[Container, None,
s.bind(("", 0))
redis_port = s.getsockname()[1]

# Determine Docker image based on version
if REDIS_VERSION.startswith("valkey-"):
version = REDIS_VERSION.replace("valkey-", "")
image = f"valkey/valkey:{version}"
else:
image = f"redis:{REDIS_VERSION}"

container = client.containers.run(
f"redis:{REDIS_VERSION}",
image,
detach=True,
ports={"6379/tcp": redis_port},
labels={
Expand Down