Skip to content

Makes the worker's start_task sync #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisguidry merged 1 commit into from
Jul 30, 2025
Merged

Makes the worker's start_task sync #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/docket/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ async def get_new_deliveries(redis: Redis) -> RedisReadGroupResponse:
count=available_slots,
)

async def start_task(message_id: RedisMessageID, message: RedisMessage) -> bool:
def start_task(message_id: RedisMessageID, message: RedisMessage) -> bool:
function_name = message[b"function"].decode()
if not (function := self.docket.tasks.get(function_name)):
logger.warning(
Expand Down Expand Up @@ -347,7 +347,7 @@ async def ack_message(redis: Redis, message_id: RedisMessageID) -> None:
if not message: # pragma: no cover
continue

task_started = await start_task(message_id, message)
task_started = start_task(message_id, message)
if not task_started:
# Other errors - delete and ack
await self._delete_known_task(redis, message)
Expand Down