Promote WinUI app to root - #6
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughAdds a new .NET 9 WinUI app and Core library with services, models, and tests; updates CI/release workflows and documentation to .NET; introduces a Visual Studio solution and props; and removes legacy Electron/Node scripts and configs. ChangesWinUI-native app introduction, core services, tests, CI/docs, and JS-era removal
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request represents a significant architectural shift, replacing the Electron-based application with a native WinUI 3 and .NET 9 implementation. The new structure includes a dedicated core logic project, a unit testing suite, and updated documentation reflecting the revised development workflow. Key feedback items include optimizing asynchronous timeout management using the built-in WaitAsync method, improving performance by replacing JSON-based object cloning with manual deep copies in the settings store, and centralizing duplicated filename sanitization logic to enhance code maintainability.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df5140c2e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1 participant
Summary\n\n- Removes the old Electron app from the root project.\n- Promotes the native WinUI app to the repository root.\n- Tracks version 0.2.0 in Directory.Build.props.\n- Updates README, agent docs, project skills, PR template, and GitHub workflows for the WinUI/.NET workflow.\n- Publishes the v0.2.0 WinUI preview release zip on GitHub Releases.\n\n## Acceptance criteria\n\n- Root project builds and tests through WsaManager.Native.sln.\n- Non-technical users can download the v0.2.0 zip from GitHub Releases.\n- Electron source/config/test scaffolding is removed.\n\n## Commands run\n\n- dotnet test WsaManager.Native.sln -p:Platform=x64 --no-restore\n- dotnet build WsaManager.Native.sln -p:Platform=x64 --no-restore\n- dotnet publish WsaManager.WinUI\WsaManager.WinUI.csproj -c Release -p:Platform=x64 -r win-x64 --self-contained true\n\n## Artifact tested\n\n- artifacts/WSA.Manager.WinUI.0.2.0.win-x64.zip\n\n## Release\n\n- https://github.com/chrisjcthomas/wsa-manager/releases/tag/v0.2.0
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation