Feature/async root engine #257
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2025 22:52
…ngine for improved async handling - Changed peerDependencies for React and ReactDOM to allow versions >=16.8.0. - Upgraded tslib to ^2.4.0 and typescript to ^4.8.4 in devDependencies. - Refactored resolveInputValues and getValueOfConnection methods in RootEngine to be async, improving handling of asynchronous operations. - Updated resolveRootNode to use async/await for better readability and error handling. - Modified useRootEngine to utilize React state and effect hooks for resolving node values asynchronously.
|
Hey yes an async version of the engine would be great. It's been on my list of things to add. This looks roughly like the right direction, the only part that probably needs some rethinking is the useRootEngine hook which probably needs to use suspense of some kind to prevent runaway executions on every render. |
added 2 commits
July 22, 2025 02:40
- Changed ContextMenu to use onClick with preventDefault instead of onMouseDown to enhance user interaction. - Updated Stage component to stop event propagation on wheel events and adjusted the rendering of the ContextMenu within a Portal for better visibility control.
… handling - Updated useRootEngine to utilize an AbortController for managing async operations and preventing state updates after unmounting. - Enhanced error handling during root node resolution to log errors only if the operation is not aborted. - Simplified the logic for setting resolved values based on the presence of nodes.
|
I have tried to address the runaway executions issue, wondering what you think of the approach, using an abort controller. Just for reference, I am including a screenshot of my use-case, and how I am now (successfully) using this. 
I realize now that without thinking I have also included a potential fix for the right click issue on Mac, but I can pull that out, as it is a bit of a different approach compared to the original code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chrisjpatty,
Submitting this for early review/guidance. I really wanted to use Flume, but I also really wanted to be able to make (HTTP) backend calls in the node resolvers, so I took a quick stab at making things async. I could not find any other way to make this work synchronously, the next node would always resolve before the request's response data was available.
This way it seems to work, but I have not tested it very rigurously. Planning to do this now as I integrate it further into our project at work.
My questions to you are these: am I going in the right direction? Is this a direction you are interested in for Flume, and would you be willing to share your thoughts about the idea of async Flume, or any other thing I should be mindful of?
Thank you for this package, I have always really liked it, and the edge and port UX and implementations are the best I have ever found.