docs: Add hex color table for all themes #355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What?** 1. Add lists of hex values for colors in all themes to README.md I pulled these values from vim/colors/* **Why?** Explicit lists make it easier for contributors to apply the theme in new programs.
|
lgtm 👍. I'd done something similar with just the hex codes. Hex codes match what'd I'd extracted (I can neither confirm, nor deny the decimal ones 😉) |
|
@cashpw and @chriskempson quick observation, the colors in the PNGs don't match all these colors though. For example, Red is 0xd43e36 (using a color picker) in https://github.com/chriskempson/tomorrow-theme?tab=readme-ov-file#tomorrow https://github.com/chriskempson/tomorrow-theme/blob/master/Images/Tomorrow-Palette.png I believe there are some other minor differences too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I pulled these values from vim/colors/*
Why?
Explicit lists make it easier for contributors to apply the theme in new programs.