Proof INTERPRETER #216 1130-1133 [draft]#956
Open
johnzhou721 wants to merge 4 commits intochrislgarry:masterfrom
Open
Proof INTERPRETER #216 1130-1133 [draft]#956johnzhou721 wants to merge 4 commits intochrislgarry:masterfrom
johnzhou721 wants to merge 4 commits intochrislgarry:masterfrom
Conversation
Collaborator
|
Correct, the first few columns (excluding comment blocks) are the line numbers, labels/references, banked memory addresses and the octal representation of the assembly instruction. We are only interested in the assembly instructions themselves and any comments. |
Author
|
@wopian I don't have the time to prove more pages, will appreciate a review on these 4 pages though. Thanks, and sorry for wasting time on a small PR like this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wopian question: I read the contributing guide as a first-timer here, but do we ignore all the columns before BRANCH, CCS, and MPAC? Thanks!
This is incomplete, I plan to proof to 1139 of INTERPRETER
Refs #217.
https://www.ibiblio.org/apollo/ScansForConversion/Comanche055/