Add application icon for Windows build - #96
Conversation
|
Warning Rate limit exceeded@christianhelle has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a Windows application icon to the build configuration by including the icon resource file in the executable build commands. The icon.ico file is added to the resources directory, and the CMakeLists.txt is updated to conditionally include the Windows icon resource when building on Windows platforms.
Key Changes
- Added icon.ico binary file to src/resources/ directory
- Updated both qt_add_executable and add_executable commands to conditionally include the Windows icon resource using generator expressions
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/resources/icon.ico | New Windows icon file containing multiple icon sizes encoded as PNG images |
| src/project/CMakeLists.txt | Updated executable build commands to conditionally include Windows icon resource using $<$<PLATFORM_ID:Windows>:${app_icon_resource_windows}> |
|
|
||
| if(COMMAND qt_add_executable) | ||
| qt_add_executable(${APP_NAME} WIN32 MACOSX_BUNDLE ${COMMON_SRCS}) | ||
| qt_add_executable(${APP_NAME} WIN32 MACOSX_BUNDLE ${COMMON_SRCS} $<$<PLATFORM_ID:Windows>:${app_icon_resource_windows}>) |
There was a problem hiding this comment.
The PR title contains a typo: 'applicaton' should be 'application'.
christianhelle
changed the title
This pull request updates the build configuration in
src/project/CMakeLists.txtto ensure that the Windows application icon resource is included when building the executable. This change makes the build process more consistent across different platforms.Build system improvements:
qt_add_executableandadd_executablecommands to conditionally include the${app_icon_resource_windows}resource when building on Windows, ensuring the application icon is properly set for Windows builds.