-
Notifications
You must be signed in to change notification settings - Fork 133
medium.com service #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
medium.com service #205
Conversation
@@ -0,0 +1,53 @@ | |||
|
|||
n($) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sepans thanks for the PR!
Any reason we need this line?
Would it be possible to be consistent with something like https://github.com/christianvuerings/jquery-lifestream/blob/master/src/services/blogger.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @christianvuerings,
Thats what I tried first. item.description
returned by medium feed is itself a html snippet so it has to be something like: html: $.tmpl( template.posted, item ) + item.descirtion
with item.description
outside of the template. By some reason it didn't work for me but maybe I was doing something wrong with the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree it doesn't look super elegant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sepans thanks for trying to figure this out together.
Do you have a good example (medium user) to test this with?
Also, I think I understand, but why do we need the n(...
, where does the n
come from?
other pieces lgtm - just one question on the PR |
Fixed that. Sorry I was feeling so guilty about not using jQuery templates, I thought thats what you meant. That
Do you want the built files to be committed with the PR? Thanks |
@sepans looking way better thanks. And definitely leave the build files out for now, we always create those as part of the release process, thanks for asking though. As for the jQuery template, I hope to find some time in the next couple of days to have a look at different options. I hope it's ok to keep this PR open for a little longer. |
basic medium.com support.