style(deps): update eslint-config to v1.0.0#240
Merged
christopher-buss merged 1 commit intodevelopfrom Apr 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the eslint-config dependency to v1.0.0 and includes several style and refactoring changes across the codebase. The key changes include:
- Converting default exports to named exports in multiple modules for consistency
- Updating thrown errors to use the Error constructor
- Adjusting dependency configurations in pnpm-workspace.yaml, eslint.config.ts, and commitlint.config.ts
Reviewed Changes
Copilot reviewed 25 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/player/data/player-data-service.ts | Changed type import and swapped default export for a named export. |
| src/server/player/character/character-service.ts | Converted default export to named export and updated error throwing syntax. |
| src/server/mtx-service.ts | Replaced thrown error strings with new Error objects and updated export style. |
| src/client/ui/react-config.tsx | Added an eslint-disable comment to address a false-positive warning. |
| src/client/ui/functions/profiler.ts | Removed an eslint-disable comment after modifying props. |
| src/client/ui/components/error-handler/* | Replaced default exports with named exports for improved consistency. |
| src/client/store/theme/theme-selector.ts | Removed an unused state parameter from the selector function. |
| src/client/player/character/character-controller.ts | Replaced coroutine.close with task.cancel and updated error throwing. |
| src/client/audio/sound-controller.ts | Updated default export to a named export. |
| pnpm-workspace.yaml | Updated and added dependency versions and configurations. |
| eslint.config.ts | Adjusted import style and added a pnpm flag to the configuration. |
| commitlint.config.ts | Simplified the configuration export using the satisfies operator. |
Files not reviewed (6)
- .npmrc: Language not supported
- .vscode/flamework-snippets.code-snippets: Language not supported
- default.project.json: Language not supported
- package.json: Language not supported
- patches/rbxts-transform-env.patch: Language not supported
- patches/roblox-ts.patch: Language not supported
Comments suppressed due to low confidence (1)
src/client/store/theme/theme-selector.ts:4
- The state parameter was removed from the selectPlayerTheme function. Verify that downstream consumers do not rely on the provided state and update call sites if necessary.
export function selectPlayerTheme(): Theme {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.