Skip to content

chore: update workflows to remove corepack references#260

Merged
christopher-buss merged 1 commit intodevelopfrom
feature/remove-corepack-commands
Sep 10, 2025
Merged

chore: update workflows to remove corepack references#260
christopher-buss merged 1 commit intodevelopfrom
feature/remove-corepack-commands

Conversation

@christopher-buss
Copy link
Copy Markdown
Owner

@christopher-buss christopher-buss commented Sep 10, 2025

We can enable corepack with the mise postinstall hook, so these references aren't needed.

Summary by CodeRabbit

  • CI
    • Updated development and release pipelines to use direct PNPM commands; no behavioral changes expected in builds.
  • Chores
    • Simplified Git hooks to run with PNPM directly, improving consistency for commit checks and linting.
  • Developer Experience
    • Added an editor setting to improve extension symlink handling.
    • Introduced environment manager settings, including a postinstall step and experimental features, to streamline local setup.

@christopher-buss christopher-buss self-assigned this Sep 10, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaces Corepack-wrapped pnpm invocations with direct pnpm commands across CI workflows and Husky hooks, adds a Mise postinstall hook to enable Corepack, enables experimental Mise settings, and adds a VS Code setting for Mise symlinked extensions with a Copilot comment.

Changes

Cohort / File(s) Summary
CI workflows (release)
.github/workflows/release.yaml, .github/workflows/release-development.yaml
Switched corepack pnpm ... to pnpm ... for install, add, and build steps; no other workflow logic changes.
Husky hooks
.husky/commit-msg, .husky/post-merge, .husky/pre-commit
Replaced corepack pnpm ... with pnpm ... in commitlint, install-on-lock-change, and lint-staged invocations.
Editor settings
.vscode/settings.json
Added mise.configureExtensionsUseSymLinks: true and a comment line for Copilot settings.
Mise configuration
mise.toml
Added [hooks] postinstall = "npx corepack enable" and [settings] experimental = true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Replace Rokit with Mise #251 — Similar changes to workflows, Husky hooks, and Mise configuration (transition away from Corepack-wrapped pnpm and add Mise integration).

Poem

A rabbit taps: pnpm, quick and clean,
No wrapper cloaks the build machine.
Hooks now hop with lighter feet,
Mise leaves breadcrumbs, tidy and neat.
In VS Code’s warren, links align—
Release paths straight, the pipelines fine.
Thump-thump: ship time, right on time.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03ccd3d and ec27a0f.

📒 Files selected for processing (7)
  • .github/workflows/release-development.yaml (1 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • .husky/commit-msg (1 hunks)
  • .husky/post-merge (1 hunks)
  • .husky/pre-commit (1 hunks)
  • .vscode/settings.json (1 hunks)
  • mise.toml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/remove-corepack-commands

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@christopher-buss christopher-buss merged commit 7bd41a9 into develop Sep 10, 2025
1 of 2 checks passed
@christopher-buss christopher-buss deleted the feature/remove-corepack-commands branch September 10, 2025 16:36
@coderabbitai coderabbitai Bot mentioned this pull request Sep 14, 2025
christopher-buss added a commit that referenced this pull request Sep 15, 2025
* docs(dev): update readme for rbxts-build instructions

* chore(deps): update dependency @eslint-react/eslint-plugin to v1.8.2

* chore(deps): update dependency jacktabscode/asphalt to v0.8.1

* feat(ui): add profiler print function

* chore(deps): update dependency rojo-rbx/rojo to v7.4.3

* chore(deps): update dependency @eslint-react/eslint-plugin to v1.9.0

* chore(deps): update actions/upload-artifact digest to 834a144

* chore(deps): update dependency @isentinel/eslint-config to v0.7.5

* chore(deps): update dependency lint-staged to v15.2.8

* chore(deps): update dependency @rbxts/types to v1.0.795 (#171)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor(ui): remove default exports

* chore(deps): update dependency @rbxts/types to v1.0.798 (#172)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @eslint-react/eslint-plugin to v1.9.1

* fix(deps): update dependency @rbxts/lapis to v0.3.4

* chore(deps): update pnpm to v9.7.0

* chore(deps): remove eslint.config.js bundler file

* chore(deps): update commitlint monorepo to v19.4.0

* chore(deps): update dependency lune-org/lune to v0.8.7

* chore(deps): update compeydev/setup-rokit action to v0.1.1

* chore(deps): update compeydev/setup-rokit action to v0.1.2

* chore(deps): update dependency @rbxts/types to v1.0.799

* fix: circular dependency error

* chore(deps): update dependency @rbxts/types to v1.0.800 (#189)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @rbxts/types to v1.0.801 (#192)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @rbxts/compiler-types to v2.3.0-types.2

* ci: remove self-hosted runner

* ci: add missing open cloud key to release develop

* ci: remove unnecessary provided auth key

* ci: remove unnecessary provided auth key

* ci: remove unnecessary gh cli install

* ci(lint): eslint errors

* chore(lint): update automatic custom class ordering

* ci: fix release action

* fix: preserve luau flags

* build(deps): update dependencies and change to alternative packages

* build(deps): update eslint config

* chore(deps): update actions/setup-node digest to 0a44ba7

* chore(deps): update dependency rojo-rbx/rojo to v7.4.4

* chore(deps): update pnpm to v9.10.0

* chore(deps): update actions/upload-artifact digest to 5076954

* chore(deps): update dependency lune-org/lune to v0.8.8

* chore(deps): update pnpm to v9.11.0

* chore(deps): update dependency @rbxts/types to v1.0.809 (#199)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build(deps): upgrade to roblox-ts v3.0.0

* chore(deps): update dependency eslint to v9.11.1

* fix(mtx): products being incorrectly handled

* ci: fix lint-staged pre-commit linting all files

* fix(deps): update dependency @rbxts/lapis to v0.3.6

* chore(deps): update dependency @rbxts/types to v1.0.810

* chore(deps): update dependency @rbxts/types to v1.0.811 (#212)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(mtx): receipt history not being saved

Due to the fact that reflex is the source of truth, if we update the lapis document directly, then
reflex will override this data as it doesn't know of this data.

* feat(mtx): add product purchase metadata

* feat(mtx): add ability to set game pass active from client

* chore(deps): update pnpm to v9.12.2

* chore(deps): update dependency jiti to v2

* chore(deps): update dependency lune-org/lune to v0.8.9

* chore(deps): update dependency eslint to v9.13.0

* ci: fix deployment actions not working with github runners

* chore(deps): update dependency @rbxts/types to v1.0.813 (#219)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency seaofvoices/darklua to v0.14.0

* chore(deps): update actions/setup-node digest to 39370e3

* chore(deps): update actions/upload-artifact digest to b4b15b8

* fix(deps): update dependency @rbxts/ui-labs to v2.3.0

* chore(deps): update dependency @eslint/config-inspector to v0.5.5

* chore(deps): update actions/checkout digest to 11bd719

* fix(deps): update dependency @rbxts/react to v17

* fix(deps): update dependency @rbxts/react-roblox to v17

* fix(deps): update dependency @rbxts/pretty-react-hooks to v0.6.1

* chore(deps): update dependency jacktabscode/asphalt to v0.9.1

* chore(deps): update actions/setup-node digest to 1d0ff46

* build(lint): update eslint-config to v0.10.0

* build(deps): update eslint-config to v1.0.0-beta.1

* build(deps): fix lockfile

* style(deps): update eslint-config to v1.0.0

* feat(ci): down wireguard tunnel to cleanup

* chore: lint files

* Replace Rokit with Mise (#251)

* ci: update compile command in release workflow

* perf: optimize eslint performance with caching (#252)

* chore(deps): update dependency ubi:seaofvoices/darklua to v0.17.1 (#258)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update workflows to remove corepack references (#260)

* style(lint): update eslint-config to v3.0.0 (#261)

* chore: update renovate configuration

* build(deps): bump package versions

* chore(deps): update actions/checkout action to v5 (#259)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency ubi:rojo-rbx/rojo to v7.5.1 (#257)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact digest to ea165f8 (#236)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/download-artifact digest to d3f86a1 (#238)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency ubi:lune-org/lune to v0.10.2 (#256)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update ncipollo/release-action digest to b7eabc9 (#242)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/download-artifact action to v5 (#250)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: remove deprecated shell script lines from post-merge hook

* ci: update workflows to use composite actions

* ci: update build environment to use ubuntu-latest

* ci: pass in secret to fix missing secret issue

* ci: move secrets to inputs

* ci: add debug check

* ci: fix incorrect input names

* build: update catalog names for release workflow

* build: update @isentinel/eslint-config to version 3.0.0-beta.8

Remove temporary action sorting from config

* ci: remove packages write permission

* ci: move wireguard ip to github variable

This allows us to update the IP if necessary without having to make changes
to the workflow file.

* chore: update pnpm-lock.yaml

* ci: update expected-ip input for deploy actions

* docs: format header correctly

* ci: resolve jq parse error in ip verification

* chore(deps): update dependency ubi:jacktabscode/asphalt to v1 (#264)

* docs: update commit instructions for clarity and formatting

* chore(deps): update patches (#263)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build: remove nmprc in favor of pnpm-workspace

* chore: update post-merge script to include mise.toml check

* chore: add packages section to pnpm-workspace.yaml

* ci: remove catalog filter installation

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: 6ixfalls <23470032+6ixfalls@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant