Skip to content

[ENH] Wire up collection forking for python #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: sicheng/04-17-_enh_wire_up_collection_forking_for_client
Choose a base branch
from

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Apr 18, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Wires up collection forking for Python client

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

Sicheng-Pan commented Apr 18, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review April 18, 2025 00:49
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch 2 times, most recently from cbdbc6d to 7db63a9 Compare April 18, 2025 18:00
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from fa7bbc5 to 59b6c06 Compare April 18, 2025 18:00
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch from 4090c17 to f09f272 Compare April 18, 2025 18:26
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 59b6c06 to b6216a2 Compare April 18, 2025 20:06
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch 2 times, most recently from 587c882 to d58e337 Compare April 18, 2025 21:13
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from b6216a2 to d74eeb7 Compare April 18, 2025 21:13
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch from d58e337 to a41a043 Compare April 18, 2025 21:21
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from d74eeb7 to 1d7c5a0 Compare April 18, 2025 21:21
@Sicheng-Pan Sicheng-Pan mentioned this pull request Apr 18, 2025
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 1d7c5a0 to 8c8ee82 Compare April 21, 2025 17:25
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch 2 times, most recently from a6aadbd to ffdcc6c Compare April 21, 2025 17:53
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 8c8ee82 to 4f173c7 Compare April 21, 2025 17:53
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_python branch from ffdcc6c to c9b045b Compare April 21, 2025 18:24
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 4f173c7 to 6adb2bc Compare April 21, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant