Skip to content

[CHORE] Fix typing on empty configuration json returned, remove validation on num_threads in python #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Apr 18, 2025

Description of changes

This PR fixes a typing error when an empty configuration json is returned during get_configuration and removes validation on num_threads in python

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

@jairad26 jairad26 marked this pull request as ready for review April 18, 2025 21:53
@jairad26 jairad26 changed the title [CHORE] Fix typing on empty configuration json returned [CHORE] Remove check for num_threads Apr 18, 2025
@jairad26 jairad26 changed the title [CHORE] Remove check for num_threads [CHORE] Fix typing on empty configuration json returned Apr 18, 2025
@jairad26 jairad26 force-pushed the jai/fix-type-error-collectionConfig branch from 521bf55 to 35251db Compare April 18, 2025 22:16
@jairad26 jairad26 changed the title [CHORE] Fix typing on empty configuration json returned [CHORE] Fix typing on empty configuration json returned, remove validation on num_threads in python Apr 18, 2025
@jairad26 jairad26 enabled auto-merge (squash) April 18, 2025 22:20
@jairad26 jairad26 merged commit 60be7e3 into main Apr 18, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants