Skip to content

[HOTFIX] revert server response with configuration_json for coll config #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Apr 19, 2025

Description of changes

This is a hotfix to revert collection configuration being returned from the rust server. This is due to client side validation which has been out since 1.0.2, which will be removed in the next PR. Because of this, in situations where clients using clients >=1.0.2 with existing invalid configuration, they will instantly be broken

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jairad26 jairad26 force-pushed the jai/remove-client-side-validation-skip-config-serialize branch from f29c14d to c870976 Compare April 19, 2025 03:16
@jairad26 jairad26 marked this pull request as ready for review April 19, 2025 03:18
@jairad26 jairad26 marked this pull request as draft April 19, 2025 03:27
@jairad26 jairad26 force-pushed the jai/remove-client-side-validation-skip-config-serialize branch from c870976 to 77686a6 Compare April 19, 2025 18:36
@jairad26 jairad26 closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant