Skip to content

[ENH]: garbage collector v2 orchestrator (supports forking) #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feat-gc-list-files-at-version-operator
Choose a base branch
from

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 7, 2025

Description of changes

Summarize the changes made by this PR.

todo:

  • move as many changes downstack as possible
  • cleanup (remove panics, address todos)
  • update proptest to reuse sparse indices between versions
  • audit tracing::debug/trace
  • add validation check (are file paths empty?)
  • log proptest stats, manually point check generated graphs
  • speed up proptest

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link

github-actions bot commented May 7, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch 3 times, most recently from c17c75a to 19f703c Compare May 8, 2025 00:13
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 0c85b47 to b989fec Compare May 13, 2025 17:35
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch 6 times, most recently from 0e2236f to c6812d0 Compare May 14, 2025 23:18
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from b989fec to b793a23 Compare May 15, 2025 16:52
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from c6812d0 to 650042e Compare May 15, 2025 16:52
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from b793a23 to 282d440 Compare May 15, 2025 20:11
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from 650042e to 7394835 Compare May 15, 2025 20:11
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 282d440 to c0389ea Compare May 15, 2025 22:38
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from 7394835 to fc6e27b Compare May 15, 2025 22:38
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from c0389ea to 8b8f1bf Compare May 15, 2025 22:43
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch 2 times, most recently from 4694a76 to 8b4d891 Compare May 15, 2025 23:02
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 8b8f1bf to 9853786 Compare May 15, 2025 23:27
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from 8b4d891 to 069241e Compare May 15, 2025 23:27
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 9853786 to fc1cd49 Compare May 15, 2025 23:34
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from 069241e to e33a3c4 Compare May 15, 2025 23:34
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from fc1cd49 to c9ec71e Compare May 15, 2025 23:36
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from e33a3c4 to c79e3f9 Compare May 15, 2025 23:36
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from c9ec71e to d357155 Compare May 15, 2025 23:38
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from c79e3f9 to 6340637 Compare May 15, 2025 23:38
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from d357155 to 414e653 Compare May 15, 2025 23:47
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch 2 times, most recently from e1dc367 to fb6b350 Compare May 15, 2025 23:54
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 414e653 to 15fc32e Compare May 16, 2025 00:26
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from fb6b350 to a91e9aa Compare May 16, 2025 00:26
@codetheweb codetheweb force-pushed the feat-gc-list-files-at-version-operator branch from 15fc32e to f29b0bf Compare May 16, 2025 16:41
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch 5 times, most recently from 93a194a to 331529e Compare May 16, 2025 21:30
@codetheweb codetheweb force-pushed the feat-gc-orchestrator-v2 branch from 331529e to d76e42d Compare May 17, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant