[BUG] Raise Error when can't deserialize configuration json from server

[jairad26]

Description of changes

This PR fixes a bug where it warns users if the configuration is not deserializable rather than raising an error, giving the users an empty config

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jairad26]

• [BUG] Raise Error when can't deserialize configuration json from server #4471 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

This PR modifies error handling in configuration deserialization by raising ValueError instead of using warnings and empty objects. It changes how undeserializable configurations are handled, returning None values for spann and hnsw configurations instead of empty objects.

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[DataTypeCheck]

Now the fallback value for configuration in from_json() constructs CollectionConfiguration(hnsw=None, spann=None, embedding_function=None). Confirm that this matches the expected constructor signature and field types. Add appropriate type annotations to CollectionConfiguration to clarify that None is valid for these fields, or provide documentation about acceptable values.

[propel-code-bot]

[CriticalError]

The warnings module is used in this file now (see usage in chromadb/api/collection_configuration.py), but it is not imported. Add the import at the top of the file to prevent runtime errors.

[propel-code-bot]

[BestPractice]

Changing from ValueError to warnings.warn and ef = None when an embedding function is not found might mask critical configuration errors. If an embedding function is specified in the configuration but cannot be located, it typically indicates a misconfiguration that should prevent the system from proceeding as if everything is normal. This could lead to a collection being created or used without the intended embedding capabilities, with the issue only becoming apparent later. Raising an error ensures such issues are addressed immediately. This approach is also more consistent with the stricter error handling for configuration loading adopted elsewhere in these changes (e.g., in chromadb/types.py).

Consider restoring the behavior of raising an error:

Suggested change

	warnings.warn(
	f"Embedding function {ef_config['name']} not found. Add @register_embedding_function decorator to the class definition.",
	stacklevel=2,
	)
	ef = None
	raise ValueError(
	f"Embedding function {ef_config['name']} not found. Add @register_embedding_function decorator to the class definition."
	)

⚡ Committable suggestion

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

[propel-code-bot]

[CriticalError]

Instead of returning a default configuration on deserialization error, now code raises ValueError. Ensure that all consumers of this method are prepared to handle this exception appropriately. If unhandled, it may lead to crashes during deserialization.

[propel-code-bot]

[DataTypeCheck]

Calls to load_collection_configuration_from_json may now receive None for configuration_json. Before calling the loader, consider explicitly validating the presence of configuration_json to provide a clearer error message.