Skip to content

[BUG]: fix dev k8s query-service-cache mount with subpath #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented May 7, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fix dev k8s volume query-service-cache mount with subPathExpr to make sure each pod owns its exclusive cache directory.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link

github-actions bot commented May 7, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jasonvigil
Copy link
Contributor

Would we want this fix for the compaction cache also?

- name: compaction-service-cache

@HammadB
Copy link
Collaborator

HammadB commented May 7, 2025

I don't think we want this fix as is - because my_member_id for the same physical node could change after a deploy, so the cache could be incoherent for that node.

We should think of an alternative that gives similar semantics for dev (in prod nodes are 1:1 with pods so this won't happen).

@MrCroxx
Copy link
Contributor Author

MrCroxx commented May 7, 2025

I don't think we want this fix as is - because my_member_id for the same physical node could change after a deploy, so the cache could be incoherent for that node.

Got it. I'm not sure which method Chroma Cloud uses to restrict the affinity. It would be better if there is some other env we can use to keep it coherent.

We should think of an alternative that gives similar semantics for dev (in prod nodes are 1:1 with pods so this won't happen).

Imo, if possible, I still prefer to use some form of coherent ID to address this issue. Firstly, using subpaths is compatible with the default 1:1 deployment. Secondly, this approach would prevent potential future expansions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants