-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: bump foyer to v0.17.2 #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: MrCroxx <[email protected]>
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Upgrade Foyer Caching Library from v0.15.3 to v0.17.2 This PR upgrades the foyer caching library from v0.15.3 to v0.17.2, which includes several enhancements to the caching system. The upgrade introduces more refined cache key/value serialization, improved throttling mechanisms, and better management of disk cache entries. The PR also updates related dependencies and adapts the codebase to conform to API changes in the new version. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
Locate a bug with version v0.17.0 and v0.17.1, fixing it. I'll bump foyer directly to v0.17.2 later. |
Description of changes
Summarize the changes made by this PR.
Changes from v0.15.3 to v0.17.2:
serde
andbincode
. (optional)serde
andbincode
optional, and disabled by default. You can enable it withserde
feature.buffer_pool_size / flushers
is not 4K-aligned.ephemeral
,hint
,location
intoCacheProperties
andHybridCacheProperties
, useinsert_with_properties()
andfetch_with_properties()
for setting them.foyer < v0.17.0
: Repleace.insert_with_hint(..)
,.insert_ephemeral(..)
, etc withinsert_with_properties(..)
andfetch_with_properties(..)
.foyer < v0.17.0
: Enable by.with_flush_on_close(true)
with the hybrid cache builder.foyer < v0.17.0
: Please set io throttling for device, instead of usingRateLimiterAmissionPicker
.fetch(..)
interface for the disk cache.foyer < v0.17.0
: Use.fetch_with_properties(..)
API and set thelocation
ofHybridCacheProperties
toLocation::OnDisk
.builder()
API forCache
andHybridCache
to create builders.tracing
feature.mixtrics
tov0.1
.Partial, Eq
forThrottle
andIopsCounter
.Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?