Skip to content

[ENH] Support regex for local Chroma #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented May 12, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Support regex filtering for local chroma

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review May 12, 2025 18:03
Copy link
Contributor

Support Regex Filtering for Local Chroma

This PR implements regular expression filtering support for local Chroma database. It enables the ability to search documents using regex patterns by implementing the previously unimplemented Regex and NotRegex operators in the SQLite metadata module and enabling the regex feature in SQLite.

Key Changes:
• Implemented Regex and NotRegex document operators in sqlite_metadata.rs
• Added regex feature to SQLite dependency in Cargo.toml
• Enabled regexp functionality in SQLite connection configuration

Affected Areas:
• rust/segment/src/sqlite_metadata.rs
• rust/sqlite/Cargo.toml
• rust/sqlite/src/config.rs

This summary was automatically generated by @propel-code-bot

@sanketkedia
Copy link
Contributor

Can you add a basic test for this?

@Sicheng-Pan Sicheng-Pan requested a review from HammadB May 12, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants