Skip to content

[BLD]: use blacksmith pull-through container image cache for Tilt cluster #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 14, 2025

Description of changes

We have been frequently seeing image pulls fail when starting Tilt in CI due to rate limiting/network issues. This configures the kind cluster to use blacksmith's provided pull-through image cache which should resolve these issues.

Test plan

How are these changes tested?

I changed the cache mirror port to be incorrect and observed that workflows immediately failed.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the bld-use-pull-through-docker-image-cache branch from aef01d5 to ca2b86e Compare May 14, 2025 16:49
@codetheweb codetheweb force-pushed the bld-use-pull-through-docker-image-cache branch from 462a939 to 72214eb Compare May 19, 2025 23:58
@codetheweb codetheweb force-pushed the bld-use-pull-through-docker-image-cache branch 7 times, most recently from 83e0639 to a5e09e6 Compare May 20, 2025 17:23
@codetheweb codetheweb force-pushed the bld-use-pull-through-docker-image-cache branch from a5e09e6 to e1c6021 Compare May 20, 2025 17:27
@codetheweb codetheweb changed the title [BLD]: use pull-through Docker image cache [BLD]: use blacksmith pull-through container image cache for Tilt cluster May 20, 2025
@codetheweb codetheweb marked this pull request as ready for review May 20, 2025 17:38
Copy link
Contributor

Configure Blacksmith Pull-through Image Cache for Tilt CI Cluster

This PR updates the GitHub Actions workflow for starting Tilt services in CI to address frequent Docker image pull failures caused by rate limiting or network issues. It replaces the direct kind cluster configuration with the use of the Blacksmith pull-through container image cache and switches to the helm/kind-action for cluster setup, ensuring more reliable image pulls.

Key Changes:
• Upgraded Tilt version from 0.33.3 to 0.34.2 in the workflow.
• Removed ctlptl installation and direct kind setup in favor of helm/kind-action@v1.
• Configured kind to use an internal registry and enabled image delete.
• Added a step that updates kind nodes to use the Blacksmith image cache as a Docker registry mirror.
• Tested failure scenarios by setting an incorrect mirror port (reverted in final commit).

Affected Areas:
• GitHub Actions workflow (.github/actions/tilt/action.yaml)
• CI infrastructure setup for Tilt/kind clusters

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb requested a review from HammadB May 20, 2025 17:39
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update hosted/ as well. Although IIRC it may use this

@codetheweb codetheweb enabled auto-merge (squash) May 20, 2025 17:41
@codetheweb codetheweb merged commit bbd92f6 into main May 20, 2025
70 checks passed
@codetheweb codetheweb deleted the bld-use-pull-through-docker-image-cache branch May 20, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants