Skip to content

[ENH] Add feature to the rust log service to proxy the go log service. #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: rescrv/wal3-bootstrap-impl
Choose a base branch
from

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented May 15, 2025

Description of changes

Following the rollout ADR, this will encode table to go
classic->transitioning->transitioned.

inactive active
open classic BUG
sealed transitioning transitioned

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv force-pushed the rescrv/rust-proxies-go branch from 613c61f to a5bd3fa Compare May 16, 2025 17:24
@rescrv rescrv changed the base branch from rescrv/sealing-log-service to rescrv/wal3-bootstrap-impl May 16, 2025 17:25
@rescrv rescrv force-pushed the rescrv/wal3-bootstrap-impl branch from 51295b2 to cad8641 Compare May 16, 2025 19:44
rescrv added 2 commits May 16, 2025 13:03
Following the rollout ADR, this will encode table to go
classic->transitioning->transitioned.

|            | **inactive**  | **active**   |
|------------|---------------|--------------|
| **open**   | classic       | BUG          |
| **sealed** | transitioning | transitioned |
@rescrv rescrv force-pushed the rescrv/rust-proxies-go branch from a5bd3fa to bb3b8b7 Compare May 16, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant