-
Notifications
You must be signed in to change notification settings - Fork 2k
[ENH] Commit eagerly in ordered blockfile writer #6109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Commit eagerly in ordered blockfile writer #6109
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
The writer now persists each completed delta into a finalized block as soon as it closes—whether through commits, swaps, or split handling—keeping track of the committed blocks, updating their sparse index counts, and routing their identifiers into the migration pipeline through an async helper used across the relevant call paths. Key Changes• Maintain Affected Areas• This summary was automatically generated by @propel-code-bot |
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - N/A - New functionality - Eagerly commit blocks in ordered blockfile writer to avoid excessive memory usage ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan _Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?_ ## Observability plan _What is the plan to instrument and monitor this change?_ ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
This PR cherry-picks the commit acde656 onto rc/2026-01-02. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Macronova <[email protected]>

Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?