Skip to content

Conversation

@tanujnay112
Copy link
Contributor

@tanujnay112 tanujnay112 commented Jan 4, 2026

Description of changes

The logic to extract the service name in go code was wrong. The logic to generate the lock name for the sysdb service during leader election was dependent on this and was faulty as a result. Every replica ended up generating different lock names.

This diff fixes that issue.

  • Improvements & Bug fixes
    • ^^
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tanujnay112 tanujnay112 marked this pull request as ready for review January 4, 2026 02:06
@propel-code-bot
Copy link
Contributor

It updates the extractServiceName helper to remove both the replica set hash and the pod hash suffixes from Kubernetes pod names so that every replica resolves the same {service-name}-leader lock key.

Key Changes

• Updated extractServiceName to drop the last two hyphen-delimited segments from pod names when available
• Clarified inline documentation to reflect Kubernetes deployment-style pod naming assumptions

This summary was automatically generated by @propel-code-bot

@tanujnay112 tanujnay112 merged commit 48152f0 into main Jan 5, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants