[ENH](frontend): block functions on topology dbs#6836
Open
rescrv wants to merge 23 commits intorescrv/mcmr-testsfrom
Open
[ENH](frontend): block functions on topology dbs#6836rescrv wants to merge 23 commits intorescrv/mcmr-testsfrom
rescrv wants to merge 23 commits intorescrv/mcmr-testsfrom
Conversation
Add backend overrides for manifest bounds and bounded fragment scans. Use the Spanner-backed manifest manager to: - derive manifest bounds without loading the full manifest - scan fragments from the compaction offset with a position_limit index - let log-service scout and pull logs through the partial-read path - expose a phase-0 garbage reset helper for GC recovery Essentially, what we can do now because of this patch is do a bounded manifest fetch. As spanner manifests grow in size, the cost of fetching the manifest begins to dominate. This adds a proportional-to-the-fragments fetch path. Co-authored-by: AI
Introduce dedicated multi-cluster multi-region (MCMR) property tests that write records across two regions and verify cross-region replication invariants. Parameterize existing test_add tests by database name so they run against both classic and MCMR databases when multi-region is enabled. Fix dirty log detection in the repl manifest manager: - Treat intrinsic_cursor=0 as unset so newly initialized logs are not spuriously reported as dirty - Initialize manifest_regions rows with intrinsic_cursor=0 instead of omitting the column, preventing GC from misinterpreting the starting offset as an active reader position - Change the SQL threshold comparison from > to >= so logs at the exact threshold boundary are correctly included - Add decode_intrinsic_cursor helper that filters out zero values Retry Spanner-aborted flush compaction transactions: - Add is_spanner_aborted() to SysDbError to detect gRPC Aborted status - Wrap the flush_collection_compaction read-write transaction with backon retry (100ms delay, 4 attempts) on Spanner abort - Propagate gRPC status codes through SysDbError and FlushCompactionError instead of mapping all Spanner errors to Internal Improve dirty log test diagnostics by dumping in-memory and Spanner state on assertion failure. Add regression tests for single-add and three-add dirty log scenarios. Co-authored-by: AI
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
Block attached function operations on topology-prefixed databases in frontend This PR adds a shared validation helper in The PR also expands endpoint tests in the same file to verify This summary was automatically generated by @propel-code-bot |
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This reverts commit 0eebd27.
Reject attached function operations when the database name carries a topology prefix, reusing the same multi-region validation path as collection forking. Add targeted frontend endpoint tests covering attach, get, and detach against topology-prefixed databases. Co-authored-by: AI
rescrv
force-pushed
the
rescrv/mcmr-deny-features
branch
from
e48877b to
9c34b92
Compare
tanujnay112
approved these changes
Apr 8, 2026
rescrv
force-pushed
the
rescrv/mcmr-tests
branch
from
4c35d83 to
18e0a5b
Compare
rescrv
force-pushed
the
rescrv/mcmr-tests
branch
from
18e0a5b to
bf7c8e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Reject attached function operations when the database name carries a
topology prefix, reusing the same multi-region validation path as
collection forking.
Add targeted frontend endpoint tests covering attach, get, and
detach against topology-prefixed databases.
Test plan
Integration tests that hit the endpoint and confirm error are included.
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI