You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduce ConfigStore Abstraction Across CLI Commands for Testable Config/Profile I/O
This PR introduces a new config/profiles persistence abstraction in rust/cli/src/config_store.rs via the ConfigStore trait and a default FileConfigStore implementation backed by existing utils file I/O functions. It also moves get_current_profile logic into this module so command code can depend on an injected store instead of direct global file reads/writes.
Multiple command modules (profile, login, browse, install, copy, db) are refactored to accept &dyn ConfigStore in core execution paths, while preserving public entrypoints that instantiate FileConfigStore. profile receives the largest update with a new run_profile_command path and expanded end-to-end tests using an in-memory test store. CliConfig and SampleAppsConfig now derive Clone to support in-memory store semantics.
This summary was automatically generated by @propel-code-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding config store abstraction to allow for better testing.