fix(async): from_system_async() now binds to the provided system

[peteroyce]

Summary

AsyncClient.from_system_async(system, ...) was ignoring the system argument and creating a fresh client stack from system.settings. This violated the documented contract ("create a client from an existing system") and was inconsistent with the sync Client.from_system().

Root Cause

The sync from_system() calls SharedSystemClient._populate_data_from_system(system) before constructing the client, which caches the existing System object. Subsequent create() calls then find and reuse that cached system via its identifier.

The async version skipped this step, so AsyncClient.create() always spun up a brand new system, giving the client a different UUID than the one passed in.

# Before (broken — ignores system)
async def from_system_async(cls, system, tenant=..., database=...) -> "AsyncClient":
    return await AsyncClient.create(tenant, database, system.settings)

# After (fixed — matches sync behaviour)
async def from_system_async(cls, system, tenant=..., database=...) -> "AsyncClient":
    SharedSystemClient._populate_data_from_system(system)
    return await AsyncClient.create(tenant, database, system.settings)

Changes

• chromadb/api/async_client.py: add SharedSystemClient._populate_data_from_system(system) call before AsyncClient.create(), mirroring the sync Client.from_system() implementation

Closes #6871

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Fix AsyncClient.from_system_async() to reuse provided System instance

This PR fixes a behavior bug in chromadb/api/async_client.py where AsyncClient.from_system_async() previously ignored the passed system object and effectively created a new client stack from system.settings. The method now first calls SharedSystemClient._populate_data_from_system(system) before invoking AsyncClient.create(...), matching the sync path behavior.

The change restores the documented contract of creating a client from an existing system and aligns async and sync semantics, preventing unintended creation of a different underlying system identity when a caller explicitly provides one.

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

Review found no issues; the async system-binding fix appears correct and low risk.

Status: No Issues Found | Risk: Low

Review Details

📁 1 files reviewed | 💬 0 comments