[BUG] Log segment metadata value in convertSegmentMetadataToModel debug output#6886
Open
cuiweixie wants to merge 1 commit intochroma-core:mainfrom
Open
[BUG] Log segment metadata value in convertSegmentMetadataToModel debug output#6886cuiweixie wants to merge 1 commit intochroma-core:mainfrom
cuiweixie wants to merge 1 commit intochroma-core:mainfrom
Conversation
…ug output The debug line passed nil to zap.Any instead of the resolved metadata, so logs never showed the converted segment metadata.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
Fix This PR makes a one-line bug fix in Behavioral impact is limited to observability: debug logs now correctly reflect converted This summary was automatically generated by @propel-code-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the
log.Debugcall inconvertSegmentMetadataToModelso it logs the resolvedmetadatainstead of always loggingnil.Why
The previous code passed
niltozap.Any, so debug output did not reflect the converted segment metadata.Fixes #6885