fix: move testcontainers to devDependencies in @chroma-core/ollama#7012
fix: move testcontainers to devDependencies in @chroma-core/ollama#7012aayushbaluni wants to merge 1 commit into
Conversation
testcontainers is only used by local tooling and tests, not by the published embedder entrypoint.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
There was a problem hiding this comment.
Review found no issues; dependency scope change and lockfile update appear appropriate and low risk.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ └── rules/
│ └── foundation-rust.md
├── AGENTS.md
└── CLAUDE.md
|
Move This PR updates
This summary was automatically generated by @propel-code-bot |
Moves
testcontainersfrom runtimedependenciestodevDependenciesin@chroma-core/ollama, since the published entry (src/index.ts) does not import it.Updates
pnpm-lock.yamlaccordingly.Fixes #6972.
Made with Cursor