Skip to content

fix: move testcontainers to devDependencies in @chroma-core/ollama#7012

Open
aayushbaluni wants to merge 1 commit into
chroma-core:mainfrom
aayushbaluni:fix/6972-ollama-testcontainers-devdep
Open

fix: move testcontainers to devDependencies in @chroma-core/ollama#7012
aayushbaluni wants to merge 1 commit into
chroma-core:mainfrom
aayushbaluni:fix/6972-ollama-testcontainers-devdep

Conversation

@aayushbaluni

Copy link
Copy Markdown

Moves testcontainers from runtime dependencies to devDependencies in @chroma-core/ollama, since the published entry (src/index.ts) does not import it.

Updates pnpm-lock.yaml accordingly.

Fixes #6972.

Made with Cursor

testcontainers is only used by local tooling and tests, not by the published embedder entrypoint.
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot propel-code-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found no issues; dependency scope change and lockfile update appear appropriate and low risk.

Status: No Issues Found | Risk: Low

Review Details

📁 2 files reviewed | 💬 0 comments

Instruction Files
├── .claude/
│   └── rules/
│       └── foundation-rust.md
├── AGENTS.md
└── CLAUDE.md

@propel-code-bot

Copy link
Copy Markdown
Contributor

Move testcontainers to devDependencies in @chroma-core/ollama

This PR updates clients/new-js/packages/ai-embeddings/ollama/package.json to move testcontainers from runtime dependencies into devDependencies, keeping ollama as a runtime dependency. The stated rationale is that the published entrypoint does not import testcontainers, so it should not be installed for consumers.

clients/new-js/pnpm-lock.yaml is regenerated to reflect the dependency-scope change. The lockfile also includes unrelated resolution drift (for example, chromadb-js-bindings 1.3.1 to 1.3.3 and added libc metadata on several platform-specific packages), which should be verified as an intentional byproduct of lockfile refresh.

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: npm package @chroma-core/ollama depends on unused "testcontainers"

1 participant