Skip to content

fix(ollama): remove unused testcontainers dependency#7013

Closed
NIK-TIGER-BILL wants to merge 1 commit into
chroma-core:mainfrom
NIK-TIGER-BILL:fix/remove-unused-testcontainers-dep
Closed

fix(ollama): remove unused testcontainers dependency#7013
NIK-TIGER-BILL wants to merge 1 commit into
chroma-core:mainfrom
NIK-TIGER-BILL:fix/remove-unused-testcontainers-dep

Conversation

@NIK-TIGER-BILL

@NIK-TIGER-BILL NIK-TIGER-BILL commented May 3, 2026

Copy link
Copy Markdown

Closing this PR as it has been open for 11+ days with only bot approval and no human maintainer review or comments. Will revisit if still relevant.

The @chroma-core/ollama package declared a dependency on 'testcontainers'
in its package.json, but the package never actually imports or uses it.
Removing the unused dependency avoids unnecessary transitive installs and
resolves the circular-dependency problem reported in chroma-core#6972.

Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot propel-code-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found no issues; removing the unused dependency is appropriate and low risk.

Status: No Issues Found | Risk: Low

Review Details

📁 1 files reviewed | 💬 0 comments

Instruction Files
├── .claude/
│   └── rules/
│       └── foundation-rust.md
├── AGENTS.md
└── CLAUDE.md

@propel-code-bot

Copy link
Copy Markdown
Contributor

Remove unused testcontainers dependency from @chroma-core/ollama

This PR updates clients/new-js/packages/ai-embeddings/ollama/package.json to remove the unused testcontainers package from dependencies, leaving only @chroma-core/ai-embeddings-common and ollama.

The change aligns with the stated intent to eliminate an unnecessary transitive dependency and address the circular-dependency issue referenced in #6972, with no production code or API behavior changes.

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant