Split share telemetry events - #444
Open
shilman wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Routes SharePopup telemetry through a dedicated Storybook channel so share-funnel events are recorded under the chromatic-share telemetry event, while existing addon panel telemetry remains under addon-visual-tests.
Changes:
- Introduced a new
SHARE_TELEMETRYchannel event constant and updated SharePopup to emit on it. - Added a server-side channel listener that forwards
SHARE_TELEMETRYto Storybook telemetry aschromatic-share. - Updated SharePopup tests to assert against the new channel event name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/screens/SharePopup/useShareExecution.ts | Switches SharePopup action telemetry emission from TELEMETRY to SHARE_TELEMETRY. |
| src/screens/SharePopup/SharePopup.test.tsx | Updates telemetry assertions to match the new shareTelemetry channel event. |
| src/preset.ts | Adds a new server channel listener to route share telemetry to the chromatic-share Storybook telemetry event. |
| src/constants.ts | Defines the new SHARE_TELEMETRY channel event constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shilman/fix-share-actions #444 +/- ##
=============================================================
+ Coverage 74.18% 74.40% +0.21%
=============================================================
Files 164 164
Lines 12923 12928 +5
Branches 1142 1148 +6
=============================================================
+ Hits 9587 9619 +32
+ Misses 3319 3292 -27
Partials 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shilman
force-pushed
the
shilman/fix-share-actions
branch
from
July 28, 2026 16:30
2e83b21 to
8d6def4
Compare
shilman
force-pushed
the
shilman/split-share-telemetry
branch
from
July 28, 2026 16:32
be97ac4 to
415d92e
Compare
shilman
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ghengeveld Have tested this canary pretty well using Yann's
npx @hipster/sb-utils event-loggerutility so I can visualize the event stream. The only bug I saw is pre-existing in the code and I've opened a repro PR at #446.Summary
Routes SharePopup telemetry through a dedicated channel and records it under the
chromatic-shareStorybook telemetry event.Panel telemetry is unchanged and continues to use
addon-visual-tests.This PR is stacked on #443.
addon-visual-testschromatic-shareTest plan
yarn gate: 221 tests pass