Release 5.3.0 - #445
Open
ghengeveld wants to merge 13 commits into
Open
Conversation
The share flow emitted telemetry from the uploading step onward, leaving the welcome, sign-in, and SSO subdomain screens dark — no way to measure drop-off before publish/auth. Emit share-welcome-viewed, share-signin-viewed, and share-sso-viewed once per screen entry, skipped when signed in since those screens auto-skip to uploading. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add view telemetry for top-of-funnel share screens
Fetch deviceScaleFactor from the public API and scale snapshot dimensions using the same logic as the Chromatic webapp, with a story using a real DPR 2 capture fixture.
Drop React Native platform DPI logic and getCapturedPixelRatio; VTA only needs getDisplayImageSize with deviceScaleFactor from the public API.
Render DPR 2 snapshots at the correct display size
Stop polling with misconfigured projectIds (often a project token) that throw in the public API ObjectId constructor and spam Sentry.
ghengeveld
added
release
ndelangen
reviewed
Jul 28, 2026
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v7 |
Member
There was a problem hiding this comment.
For security reasons, it's recommended to pick an exact SHA, can't say that's very convenient, I agree, but it's necessary nowadays.
ndelangen
reviewed
Jul 28, 2026
ndelangen
approved these changes
Jul 28, 2026
|
@ghengeveld I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly. You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
projectIdbefore making API requests