Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prom conversion: Always set recording rule execution group #52

Conversation

bbarnes52
Copy link
Contributor

@bbarnes52 bbarnes52 commented Feb 4, 2025

Recording rules must set at least one of BucketSlug and ExecutionGroup. Currently the ConvertPrometheus function will return recording rules with neither BucketSlug nor ExecutionGroup if the UseBuckets option is set.

This PR addresses the issue by always setting ExecutionGroup irrespective of whether UseBuckets is set.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bbarnes52 bbarnes52 force-pushed the 01-31-prom_conversion_always_set_recording_rule_execution_group branch from bab32a2 to a4f2ad4 Compare February 4, 2025 02:03
@bbarnes52 bbarnes52 force-pushed the 01-31-prom_conversion_always_set_recording_rule_execution_group branch from 8b09beb to 5c5e169 Compare February 4, 2025 02:10
@bbarnes52 bbarnes52 marked this pull request as ready for review February 4, 2025 03:47
@bbarnes52 bbarnes52 requested a review from a team as a code owner February 4, 2025 03:47
@bbarnes52 bbarnes52 merged commit 93c9103 into main Feb 4, 2025
1 check passed
@bbarnes52 bbarnes52 deleted the 01-31-prom_conversion_always_set_recording_rule_execution_group branch February 4, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants