prom conversion: Always set recording rule execution group #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarnes52
force-pushed
the
01-31-prom_conversion_always_set_recording_rule_execution_group
branch
from
bab32a2 to
a4f2ad4
Compare
bbarnes52
force-pushed
the
01-31-prom_conversion_always_set_recording_rule_execution_group
branch
from
8b09beb to
5c5e169
Compare
prashantv
approved these changes
Feb 4, 2025
bbarnes52
deleted the
01-31-prom_conversion_always_set_recording_rule_execution_group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording rules must set at least one of BucketSlug and ExecutionGroup. Currently the ConvertPrometheus function will return recording rules with neither BucketSlug nor ExecutionGroup if the UseBuckets option is set.
This PR addresses the issue by always setting ExecutionGroup irrespective of whether UseBuckets is set.