-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import latest models #53
Conversation
@@ -1539,7 +1598,7 @@ | |||
"type": "string" | |||
}, | |||
"allocation": { | |||
"$ref": "#/definitions/ResourcePoolsAllocation" | |||
"$ref": "#/definitions/configv1ResourcePoolsAllocation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected? Between the ref change and many file renames, I can't tell if there's a tooling change or versioning issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly not sure what that's about. All I did was the swagger update. Maybe someone on programmable platform will be aware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let them chime in because I don't really know how this stuff works 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bg451 might be the best to say for sure. I can dig in a bit and see what i can find. IIRC the $ref stuff in swagger spec is just pointing to a type although i wonder if it would cause a different type to be generated in the case of client generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our swagger generator was bumped versions about a month ago. Generally, ref renames are safe and are not a breaking change. Additionally, the contract here is around the API itself, not the swagger config or generated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending changelog updates!
Updating the latest generated models for configv1/configunstable