Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import latest models #53

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Import latest models #53

merged 3 commits into from
Feb 17, 2025

Conversation

rallen090
Copy link
Member

@rallen090 rallen090 commented Feb 14, 2025

Updating the latest generated models for configv1/configunstable

@rallen090 rallen090 requested a review from a team as a code owner February 14, 2025 22:56
@@ -1539,7 +1598,7 @@
"type": "string"
},
"allocation": {
"$ref": "#/definitions/ResourcePoolsAllocation"
"$ref": "#/definitions/configv1ResourcePoolsAllocation"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected? Between the ref change and many file renames, I can't tell if there's a tooling change or versioning issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not sure what that's about. All I did was the swagger update. Maybe someone on programmable platform will be aware

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let them chime in because I don't really know how this stuff works 😬

Copy link
Contributor

@aschepis aschepis Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bg451 might be the best to say for sure. I can dig in a bit and see what i can find. IIRC the $ref stuff in swagger spec is just pointing to a type although i wonder if it would cause a different type to be generated in the case of client generation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our swagger generator was bumped versions about a month ago. Generally, ref renames are safe and are not a breaking change. Additionally, the contract here is around the API itself, not the swagger config or generated code.

Copy link
Collaborator

@bg451 bg451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending changelog updates!

@rallen090 rallen090 merged commit a9f97fa into main Feb 17, 2025
1 check passed
@rallen090 rallen090 deleted the ra/latest-models branch February 17, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants